Skip to content

KAFKA-20127: Add new methods to StateSerdes#21411

Merged
mjsax merged 8 commits intoapache:trunkfrom
frankvicky:KAFKA-20127
Feb 11, 2026
Merged

KAFKA-20127: Add new methods to StateSerdes#21411
mjsax merged 8 commits intoapache:trunkfrom
frankvicky:KAFKA-20127

Conversation

@frankvicky
Copy link
Contributor

@frankvicky frankvicky commented Feb 5, 2026

This PR is part of implementation of KIP-1271, adding new methods to
enable storing headers in state store.

Reviewers: Alieh Saeedi asaeedi@confluent.io, Matthias J. Sax
matthias@confluent.io

@github-actions github-actions bot added triage PRs from the community streams labels Feb 5, 2026
* @param rawKey the key as raw bytes
* @return the key as typed object
*/
@Deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that make sense to replace this deprecated method with the newly introduced one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that we should add @SupressWarning and replace them in follow-up PRs.

@frankvicky frankvicky force-pushed the KAFKA-20127 branch 4 times, most recently from 847d808 to d5fdfb2 Compare February 6, 2026 20:30
* @param rawValue the value as raw bytes
* @return the value as typed object
*/
public V valueFrom(final byte[] rawValue, Headers headers) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing final

@github-actions github-actions bot removed the triage PRs from the community label Feb 7, 2026
@mjsax mjsax added kip Requires or implements a KIP ci-approved labels Feb 10, 2026
Copy link
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mjsax mjsax merged commit 75d26f2 into apache:trunk Feb 11, 2026
23 checks passed
@mjsax
Copy link
Member

mjsax commented Feb 11, 2026

Thanks for the PR. Merged to trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-approved kip Requires or implements a KIP streams

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants