MINOR: reenabled checkstyle rules for finals for the streams module.#21456
Merged
mjsax merged 3 commits intoapache:trunkfrom Feb 11, 2026
Merged
Conversation
Fixed the checkstyle violations.
Contributor
Author
|
the original change: #20726 |
mjsax
approved these changes
Feb 11, 2026
Member
|
Thanks for the fix! Merged to |
chia7712
reviewed
Feb 11, 2026
|
|
||
| <!-- suppress FinalLocalVariable outside of the streams package. --> | ||
| <!-- suppress FinalLocalVariable and FinalParameters outside of the streams package. --> | ||
| <suppress checks="FinalLocalVariable" |
Member
There was a problem hiding this comment.
Thanks for the fix. I agree that keeping the rule for the streams module is the better approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the checkstyle violations.
Reviewers: Matthias J. Sax matthias@confluent.io