KAFKA-19976: Deprecate streams-scala module#21480
Open
FrankYang0529 wants to merge 4 commits intoapache:trunkfrom
Open
KAFKA-19976: Deprecate streams-scala module#21480FrankYang0529 wants to merge 4 commits intoapache:trunkfrom
FrankYang0529 wants to merge 4 commits intoapache:trunkfrom
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
KAFKA-19976
branch
from
652e9fa to
2b39726
Compare
chia7712
reviewed
Feb 15, 2026
Signed-off-by: PoAn Yang <payang@apache.org>
Member
Author
|
@chia7712 Thanks for the review. Updated it. |
mjsax
reviewed
Feb 16, 2026
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
Can we also add something to docs/streams/upgrade-guide.md ?
chia7712
reviewed
Feb 18, 2026
| * @param inner The underlying Java abstraction for KTable | ||
| * @see `org.apache.kafka.streams.kstream.KTable` | ||
| */ | ||
| @deprecated("Use `org.apache.kafka.streams.kstream.KTable` instead", "4.0.0") |
| import org.apache.kafka.common.serialization.{Deserializer, Serde, Serdes => JSerdes, Serializer} | ||
| import org.apache.kafka.streams.kstream.WindowedSerdes | ||
|
|
||
| @deprecated("Use org.apache.kafka.common.serialization.Serdes instead", "3.0.0") |
| props.put(StreamsConfig.APPLICATION_ID_CONFIG, "wordcount") | ||
| props.put(StreamsConfig.BOOTSTRAP_SERVERS_CONFIG, "localhost:9092") | ||
| // Configure default serdes | ||
| props.put(StreamsConfig.DEFAULT_KEY_SERDE_CLASS_CONFIG, Serdes.StringSerde.class) |
Member
There was a problem hiding this comment.
Serdes.StringSerde.class -> Serdes.StringSerde.getClass
Member
There was a problem hiding this comment.
Both would work. Personally, I actually thing .class is better.
Member
There was a problem hiding this comment.
Ugh, I think both of us are just Scala tourists here. 😅 Since the example is written in Scala, the correct way should actually be classOf[Serdes.StringSerde].
| props.put(StreamsConfig.BOOTSTRAP_SERVERS_CONFIG, "localhost:9092") | ||
| // Configure default serdes | ||
| props.put(StreamsConfig.DEFAULT_KEY_SERDE_CLASS_CONFIG, Serdes.StringSerde.class) | ||
| props.put(StreamsConfig.DEFAULT_VALUE_SERDE_CLASS_CONFIG, Serdes.StringSerde.class) |
Signed-off-by: PoAn Yang <payang@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KIP-1244: https://cwiki.apache.org/confluence/x/r4LMFw