Merged
Conversation
HeadersSerialzier and HeaderDeserializer are internal classes and there is no reason why they would need to implement the public Serializer and Deserializer interfaces. If we don't implement these interfaces, the actuall serialize() and deserialize() methods can be static simplifiying the code further.
| final int headersSize = ByteUtils.readVarint(buffer); | ||
|
|
||
| final byte[] rawHeaders = readBytes(buffer, headersSize); | ||
| final Headers headers = headersDeserializer.deserialize(topic, rawHeaders); |
Contributor
There was a problem hiding this comment.
Makes sense to me. Reviewing other PRs, I was all the time thinking about the topic that we dont need it at all.
aliehsaeedii
approved these changes
Feb 19, 2026
Contributor
aliehsaeedii
left a comment
aliehsaeedii
left a comment
There was a problem hiding this comment.
Thanks @mjsax. The improvement makes sense to me.
| @@ -52,20 +52,17 @@ | |||
| public class ValueTimestampHeadersSerializer<V> implements WrappingNullableSerializer<ValueTimestampHeaders<V>, Void, V> { | |||
Contributor
There was a problem hiding this comment.
Why is this class public while ValueTimestampHeadersDeserializer is package-private?
Member
Author
There was a problem hiding this comment.
No idea -- but I think it can be package private. Actually same for HeadersSerializer and HeadersDeserializer. Let me make this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HeadersSerializer and HeaderDeserializer are internal classes and there
is no reason why they would need to implement the public Serializer and
Deserializer interfaces. If we don't implement these interfaces, the
actual serialize() and deserialize() methods can be static simplifying
the code further.
Reviewers: Alieh Saeedi asaeedi@confluent.io, TengYao Chi
frankvicky@apache.org