MINOR: refactor Kafka Streams "segment" code#21520
Open
mjsax wants to merge 4 commits intoapache:trunkfrom
Open
MINOR: refactor Kafka Streams "segment" code#21520mjsax wants to merge 4 commits intoapache:trunkfrom
mjsax wants to merge 4 commits intoapache:trunkfrom
Conversation
All implementations of Segment also implement Comparable. We can let Segment extend Comparable directly to reduce code duplication.
mjsax
changed the title
…o AbstractSegments
mjsax
changed the title
aliehsaeedii
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All implementations of Segment implement Comparable. We can let Segment
extend Comparable directly to reduce code duplication.
All sub-classes of AbstractSegments have very similar implementations of
getOrCreateSegment(). We can move the shared code into AbstractSegments.
This PR also removes unused methods from SegmentedByteStore.