KAFKA-20297: move Scheduler from client common to trogdor#21753
Open
cychiu8 wants to merge 2 commits intoapache:trunkfrom
Open
KAFKA-20297: move Scheduler from client common to trogdor#21753cychiu8 wants to merge 2 commits intoapache:trunkfrom
cychiu8 wants to merge 2 commits intoapache:trunkfrom
Conversation
…ocal mock scheduler for client test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the Scheduler utility and its implementations by moving them from the
clientsmodule to thetrogdormodule. It also ensures that client-side tests that previously relied on MockScheduler remainfunctional by implementing a local version where needed.
Key Changes
Scheduler,SystemScheduler, andMockSchedulerfromorg.apache.kafka.common.utilsto
org.apache.kafka.trogdor.common.Agent,Coordinator,TaskManager,and
WorkerManager) to point to the new location of the Scheduler interface and its implementations.MockSchedulerinner class toExpiringCredentialRefreshingLoginTest.java. This replaces the dependency on the global MockScheduler thatwas moved to Trogdor, keeping the clients module tests decoupled from trogdor.
architectural shift.