KAFKA-19752 Move parts of UnifiedLogTest to storage module#21763
Merged
FrankYang0529 merged 5 commits intoapache:trunkfrom Mar 17, 2026
Merged
KAFKA-19752 Move parts of UnifiedLogTest to storage module#21763FrankYang0529 merged 5 commits intoapache:trunkfrom
FrankYang0529 merged 5 commits intoapache:trunkfrom
Conversation
github-actions
bot
added
triage
FrankYang0529
approved these changes
Mar 16, 2026
Member
FrankYang0529
left a comment
FrankYang0529
left a comment
There was a problem hiding this comment.
Overall LGTM. Thanks for the PR.
storage/src/test/java/org/apache/kafka/storage/internals/log/UnifiedLogTest.java
Outdated
Show resolved
Hide resolved
storage/src/test/java/org/apache/kafka/storage/internals/log/UnifiedLogTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
-182
to
-185
| /** | ||
| * After loading the log, producer state is truncated such that there are no producer state snapshot files which | ||
| * exceed the log end offset. This test verifies that these are removed. | ||
| */ |
Member
There was a problem hiding this comment.
Could you also move this to new file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testRetentionIdempotency ~ testLogRollAfterLogHandlerClosed
Reviewers: PoAn Yang payang@apache.org