MINOR: Migrate controllerSocketTimeoutMs from KafkaConfig to AbstractKafkaConfig#22188
Open
yunchipang wants to merge 2 commits intoapache:trunkfrom
Open
MINOR: Migrate controllerSocketTimeoutMs from KafkaConfig to AbstractKafkaConfig#22188yunchipang wants to merge 2 commits intoapache:trunkfrom
yunchipang wants to merge 2 commits intoapache:trunkfrom
Conversation
github-actions
Bot
added
triage
Contributor
|
Would it be better to make another related change https://github.com/apache/kafka/blob/be36babf5567d34de5ec8aaf67de16c5fbc8932d/serv[…]java/org/apache/kafka/server/NodeToControllerRequestThread.java in the same PR ? |
…TimeoutMs directly instead of AbstractConfig
muralibasani
reviewed
May 3, 2026
| @@ -98,7 +92,7 @@ void testRetryTimeoutWhileControllerNotAvailable() { | |||
| long retryTimeoutMs = 30000; | |||
| NodeToControllerRequestThread testRequestThread = new NodeToControllerRequestThread( | |||
Contributor
There was a problem hiding this comment.
Just realized this object testRequestThread creation steps are repeated multiple times. Refactoring this to a util method is better ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
controllerSocketTimeoutMstoAbstractKafkaConfigNodeToControllerChannelManagerImpl