Skip to content

Caching immutable voterKeys #22198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ppatierno wants to merge 1 commit into
base: trunk
Choose a base branch
from
+5 −5
Open

Caching immutable voterKeys #22198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions raft/src/main/java/org/apache/kafka/raft/VoterSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,13 @@
*/
public final class VoterSet {
private final Map<Integer, VoterNode> voters;
private final Set<ReplicaKey> voterKeys;

private VoterSet(Map<Integer, VoterNode> voters) {
this.voters = voters;
this.voterKeys = voters.values().stream()
.map(VoterNode::voterKey)
.collect(Collectors.toUnmodifiableSet());
}

/**
Expand Down Expand Up @@ -144,11 +148,7 @@ public Set<Integer> voterIds() {
* Returns all of the voters.
*/
public Set<ReplicaKey> voterKeys() {
return voters
.values()
.stream()
.map(VoterNode::voterKey)
.collect(Collectors.toSet());
return voterKeys;
}

/**
Expand Down