KAFKA-18389: Preserve votedKey when transitioning to leader state#22203
Open
lh0156 wants to merge 1 commit intoapache:trunkfrom
Open
KAFKA-18389: Preserve votedKey when transitioning to leader state#22203lh0156 wants to merge 1 commit intoapache:trunkfrom
lh0156 wants to merge 1 commit intoapache:trunkfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This patch preserves the candidate
votedKeywhen transitioning toLeaderState.Before this change,
LeaderState.election()always returned an elected-leaderElectionStatewith an emptyvotedKey. SinceQuorumState.transitionToLeaderwrites the new state's election state to the quorum state store, the candidate's self-vote could be dropped during the candidate-to-leader transition.The patch passes the candidate election state's
votedKeyintoLeaderStateand keeps the same value across the softResignedStaterepresentation. This keeps the in-memory and persisted election-state representation consistent after a candidate becomes leader and later resigns.Testing