-
Notifications
You must be signed in to change notification settings - Fork 15.2k
MINOR: Narrow remote copy lag validator props to Map<String, ?> and update the upgrade doc for KIP-1241 #22363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jiafu1115
wants to merge
7
commits into
apache:trunk
Choose a base branch
from
jiafu1115:followupRemoteStorage
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6c54d4c
MINOR:MINOR: Narrow remote copy lag validator props to Map<String, ?>
jiafu1115 6327e6f
MINOR:Update upgrade document for KIP-1241
jiafu1115 2b4e796
MINOR: Update upgrade document for KIP-1241
jiafu1115 21e1521
Revert "MINOR: Update upgrade document for KIP-1241"
jiafu1115 dccd616
Revert "MINOR:Update upgrade document for KIP-1241"
jiafu1115 b5798fd
MINOR: Update upgrade document for KIP-1241
jiafu1115 3c3c675
Merge branch 'apache:trunk' into followupRemoteStorage
jiafu1115 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind also addressing this comment #20913 (comment) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chia7712 ack
Let me take some time to look into it.
thanks a lot!