Skip to content

KAFKA-20619: ClusterTestExtensions skip jdk.internal.ref.CleanerImpl … #22386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edoardocomar wants to merge 1 commit into
base: trunk
Choose a base branch
from
+6 −2
Open

KAFKA-20619: ClusterTestExtensions skip jdk.internal.ref.CleanerImpl … #22386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...ommon-runtime/src/main/java/org/apache/kafka/common/test/junit/ClusterTestExtensions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,12 @@ public class ClusterTestExtensions implements TestTemplateInvocationContextProvi
private static final String ATTACH_LISTENER_THREAD_PREFIX = "Attach Listener";
private static final String PROCESS_REAPER_THREAD_PREFIX = "process reaper";
private static final String RMI_THREAD_PREFIX = "RMI";
private static final String JDK_INTERNAL_CLEANERIMPL_THREAD_PREFIX = "Cleaner-";

private static final String DETECT_THREAD_LEAK_KEY = "detectThreadLeak";
private static final Set<String> SKIPPED_THREAD_PREFIX = Set.of(METRICS_METER_TICK_THREAD_PREFIX, SCALA_THREAD_PREFIX,
FORK_JOIN_POOL_THREAD_PREFIX, JUNIT_THREAD_PREFIX, ATTACH_LISTENER_THREAD_PREFIX, PROCESS_REAPER_THREAD_PREFIX,
RMI_THREAD_PREFIX, SystemTimer.SYSTEM_TIMER_THREAD_PREFIX);
RMI_THREAD_PREFIX, SystemTimer.SYSTEM_TIMER_THREAD_PREFIX, JDK_INTERNAL_CLEANERIMPL_THREAD_PREFIX);

@Override
public boolean supportsTestTemplate(ExtensionContext context) {
Expand Down Expand Up @@ -182,7 +184,9 @@ public void afterEach(ExtensionContext context) {
}
List<Thread> threads = detectThreadLeak.newThreads();
assertTrue(threads.isEmpty(), "Thread leak detected: " +
threads.stream().map(Thread::getName).collect(Collectors.joining(", ")));
threads.stream().map(t -> {
return t.getThreadGroup().getName() + "/" + t.getName();
}).collect(Collectors.joining(", ")));
}
}

Expand Down
Loading