MINOR: Add generic config type to BrokerReconfigurable#22409
Open
unknowntpo wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
triage
chia7712
reviewed
May 29, 2026
| * </ol> | ||
| */ | ||
| public class LogCleaner implements BrokerReconfigurable { | ||
| public class LogCleaner implements BrokerReconfigurable<AbstractConfig> { |
Member
There was a problem hiding this comment.
From another perspective, we could move BrokerReconfigurable back to the server module, and then create server-only dynamic adapters for those classes located in non-server modules. The advantage is that BrokerReconfigurable could use AbstractKafkaConfig directly, which is simple and straightforward. The downside is that we need to create those adapters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
BrokerReconfigurablegeneric over the acceptedAbstractConfigtype and update existing implementers accordingly.
With this PR, the component that implements
BrokerReconfigurablecandecide the type of the config, and don't need type assertion to get the
actual type anymore.
Ref: #22353 (comment)
Reviewers: Ken Huang s7133700@gmail.com, Chia-Ping Tsai
chia7712@gmail.com