Skip to content

MINOR: Add generic config type to BrokerReconfigurable #22409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
unknowntpo wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

MINOR: Add generic config type to BrokerReconfigurable #22409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ class DynamicBrokerConfig(private val kafkaConfig: KafkaConfig) extends Logging
reconfigurables.add(reconfigurable)
}

def addBrokerReconfigurable(reconfigurable: config.BrokerReconfigurable): Unit = {
def addBrokerReconfigurable(reconfigurable: config.BrokerReconfigurable[_ >: KafkaConfig]): Unit = {
verifyReconfigurableConfigs(reconfigurable.reconfigurableConfigs)
brokerReconfigurables.add(new BrokerReconfigurable {
override def reconfigurableConfigs: util.Set[String] = reconfigurable.reconfigurableConfigs
Expand Down
8 changes: 5 additions & 3 deletions server-common/src/main/java/org/apache/kafka/config/BrokerReconfigurable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,10 @@
* <li>Validating the new configuration before applying it via {@link #validateReconfiguration(AbstractConfig)}</li>
* <li>Applying the new configuration via {@link #reconfigure(AbstractConfig, AbstractConfig)}</li>
* </ol>
*
* @param <T> the configuration type used by the reconfigurable component
*/
public interface BrokerReconfigurable {
public interface BrokerReconfigurable<T extends AbstractConfig> {
/**
* Returns the set of configuration keys that can be dynamically reconfigured.
*
Expand All @@ -53,7 +55,7 @@ public interface BrokerReconfigurable {
*
* @param newConfig the new configuration to validate
*/
void validateReconfiguration(AbstractConfig newConfig);
void validateReconfiguration(T newConfig);

/**
* Applies the new configuration.
Expand All @@ -63,5 +65,5 @@ public interface BrokerReconfigurable {
* @param oldConfig the previous configuration
* @param newConfig the new configuration to apply
*/
void reconfigure(AbstractConfig oldConfig, AbstractConfig newConfig);
void reconfigure(T oldConfig, T newConfig);
}
2 changes: 1 addition & 1 deletion server/src/main/java/org/apache/kafka/server/config/DynamicProducerStateManagerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

import java.util.Set;

public class DynamicProducerStateManagerConfig implements BrokerReconfigurable {
public class DynamicProducerStateManagerConfig implements BrokerReconfigurable<AbstractConfig> {
private final Logger log = LoggerFactory.getLogger(DynamicProducerStateManagerConfig.class);
private final ProducerStateManagerConfig producerStateManagerConfig;

Expand Down
2 changes: 1 addition & 1 deletion storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleaner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
* tombstone deletion.</li>
* </ol>
*/
public class LogCleaner implements BrokerReconfigurable {
public class LogCleaner implements BrokerReconfigurable<AbstractConfig> {
Copy link
Copy Markdown
Member

@chia7712 chia7712 May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From another perspective, we could move BrokerReconfigurable back to the server module, and then create server-only dynamic adapters for those classes located in non-server modules. The advantage is that BrokerReconfigurable could use AbstractKafkaConfig directly, which is simple and straightforward. The downside is that we need to create those adapters

private static final Logger LOG = LoggerFactory.getLogger(LogCleaner.class);

public static final Set<String> RECONFIGURABLE_CONFIGS = Set.of(
Expand Down
Loading