Skip to content

MINOR: remove stale zk comment #22420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chia7712 merged 1 commit into from
May 30, 2026
+0 −2
Merged

MINOR: remove stale zk comment #22420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,6 @@ public void stopPartitions(Set<StopPartition> stopPartitions,

// We want to remote topicId map and stopPartition on RLMM for deleteLocalLog or stopRLMM partitions because
// in both case, they all mean the topic will not be held in this broker anymore.
// NOTE: In ZK mode, this#stopPartitions method is called when Replica state changes to Offline and ReplicaDeletionStarted
Set<TopicIdPartition> pendingActionsPartitions = stopPartitions.stream()
.filter(sp -> (sp.stopRemoteLogMetadataManager || sp.deleteLocalLog) && topicIdByPartitionMap.containsKey(sp.topicPartition))
.map(sp -> new TopicIdPartition(topicIdByPartitionMap.get(sp.topicPartition), sp.topicPartition))
Expand Down
1 change: 0 additions & 1 deletion .../apache/kafka/tiered/storage/integration/DeleteSegmentsDueToLogStartOffsetBreachTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ private void executeDeleteSegmentsDueToLogStartOffsetBreachTest(ClusterInstance
.expectDeletionInRemoteStorage(broker0, topicA, p0, DELETE_SEGMENT, 1)
.deleteRecords(topicA, p0, beforeOffset)
// expect that the leader epoch checkpoint is updated
// Comment out this line if it's FLAKY since the leader-epoch is not deterministic in ZK mode.
.expectLeaderEpochCheckpoint(broker0, topicA, p0, beginEpoch, startOffset)
// consume from the offset-3 of the topic to read data from local and remote storage
.expectFetchFromTieredStorage(broker0, topicA, p0, 1)
Expand Down
Loading