KAFKA-20847: Carry record metadata on suppress buffer changelog tombstones - #22983
Open
nileshkumar3 wants to merge 2 commits into
Open
KAFKA-20847: Carry record metadata on suppress buffer changelog tombstones#22983nileshkumar3 wants to merge 2 commits into
nileshkumar3 wants to merge 2 commits into
Conversation
nileshkumar3
force-pushed
the
KAFKA-20847
branch
from
July 29, 2026 01:40
54ea328 to
68ff31f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a key is evicted from the suppression buffer,
InMemoryTimeOrderedKeyValueChangeBuffer writes a delete marker to the
changelog so the topic can be compacted. That tombstone was written with
no metadata at all (null timestamp and null headers), because the row and
its ProcessorRecordContext were already discarded during evictWhile by the
time commit() fires.
Streams itself does not need this on the restore path (the key is passed
through as raw Bytes), but it makes the tombstone impossible to interpret
for anything else reading the changelog, and it is inconsistent with the
header-aware stores, whose delete path keeps the record self-describing.