Skip to content

KNOX-3136 removed write-only object #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KNOX-3136 removed write-only object #1031

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions gateway-util-urltemplate/src/main/java/org/apache/knox/gateway/util/urltemplate/Matcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,6 @@ private void pickMatchingOptionalSegment( Segment segment, Status status ) {
}

private Match pickBestMatch( Template input, Status status ) {
Match bestMatch = new Match( null, null );
PathNode bestPath = null;
QueryNode bestQuery = null;
MatchSegment bestMatchSegment = null;
Expand All @@ -220,17 +219,13 @@ private Match pickBestMatch( Template input, Status status ) {
if( pathNode.template != null ) {
bestPath = pathNode;
bestQuery = null;
bestMatch.template = pathNode.template;
bestMatch.value = pathNode.value;
bestMatchSegment = matchSegment;
}
// If the path node has queries see if one is better match than the path node itself.
if( pathNode.hasQueries() ) {
bestQuery = pickBestQueryMatch( input, pathNode );
if( bestQuery != null && bestQuery.template != null ) {
bestPath = pathNode;
bestMatch.template = bestQuery.template;
bestMatch.value = bestQuery.value;
bestMatchSegment = matchSegment;
}
}
Expand Down
Loading