Improve Logo Visibility in Light and Dark Modes #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses two logo visibility issues: 1. User logos are now displayed on a white background in dark theme to provide proper contrast 2. Feature icons on the homepage (particularly namespace logo) now have a subtle drop shadow to improve visibility against light backgrounds
Merged
PragmaTwice
approved these changes
Mar 13, 2025
|
Looks good to me. Thank you! |
No need to thank me, sir. I love contributing to open source and helping communities. My efforts are nothing compared to your amazing work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the CSS styles for the
HomepageFeaturesandUserLogoscomponents to improve visual presentation and theme support.Styling improvements:
src/components/HomepageFeatures/styles.module.css: Added a drop shadow to the.imgItemclass to enhance the visual appearance.static/img/namespace.pngandstatic/img/replication.pngto remove the white background, ensuring they look proper in both dark and light modes.Theme support:
src/components/UserLogos/index.module.css: Added a background color and border styling for elements with thedata-theme='dark'attribute to ensure proper display in dark mode.Before vs After
🔴 Before
old.mov
🟢 After
Watch Before Video
Please review @PragmaTwice and @git-hulk. If you have any suggestions or changes, let me know I’d love to improve and collaborate with you😊