Merge pull request #40 from meitu/refactor/config-base-code

refactor the config code base and make it clearly

Author: karelrooted

CMakeLists.txt

@@ -121,6 +121,7 @@ target_sources(kvrocks PRIVATE
         src/rocksdb_crc32c.h
         src/config.cc
         src/config.h
+        src/config_type.h
         src/stats.cc
         src/stats.h
         src/server.cc
@@ -204,6 +205,7 @@ target_sources(kvrocks2redis PRIVATE
         src/rocksdb_crc32c.h
         src/config.cc
         src/config.h
+        src/config_type.h
         src/stats.cc
         src/stats.h
         src/server.cc
@@ -258,6 +260,8 @@ add_executable(unittest
         src/redis_zset.cc
         src/redis_sortedint.cc
         src/redis_sortedint.h
+        src/redis_slot.cc
+        src/redis_slot.h
         src/util.cc
         src/storage.cc
         src/lock_manager.cc
@@ -287,7 +291,7 @@ add_executable(unittest
         tests/task_runner_test.cc
         tests/t_bitmap_test.cc
         tests/compact_test.cc
-        tests/log_collector_test.cc)
+        tests/log_collector_test.cc src/config_type.h)
 
 add_dependencies(unittest glog rocksdb snappy jemalloc)
 target_compile_features(unittest PRIVATE cxx_std_11)

kvrocks.conf

@@ -24,10 +24,6 @@ workers 8
 # Default: 1
 repl-workers 1
 
-# The value should be INFO, WARNING, ERROR, FATAL
-# Default: INFO
-loglevel INFO
-
 # By default kvrocks does not run as a daemon. Use 'yes' if you need it.
 # Note that kvrocks will write a pid file in /var/run/kvrocks.pid when daemonized.
 daemonize no
@@ -73,16 +69,10 @@ db-name change.me.db
 # Note that you must specify a directory here, not a file name.
 dir /tmp/kvrocks
 
-# The backup directory
-#
-# The DB will be written inside this directory
-# Note that you must specify a directory here, not a file name.
-# kvrocks will create backup directory in ${CONFIG_DIR}/backup by default.
-# backup-dir /tmp/kvrocks/backup
-
 # When running daemonized, kvrocks writes a pid file in ${CONFIG_DIR}/kvrocks.pid by
 # default. You can specify a custom pid file location here.
 # pidfile /var/run/kvrocks.pid
+pidfile ""
 
 # You can configure a slave instance to accept writes or not. Writing against
 # a slave instance may be useful to store some ephemeral data (because data
@@ -178,8 +168,24 @@ max-backup-keep-hours 168
 # Enable the kvrocks to support the codis protocol, if the db enabled the codis mode at first open, 
 # this option must not be disabled after restarted, and vice versa
 # Defalut: no
-# codis-enabled yes
+codis-enabled no
 
+# Ratio of the samples would be recorded when the profiling was enabled. 
+# we simply use the rand to determine whether to record the sample or not.
+# 
+# Default: 0
+profiling-sample-ratio 0
+
+# There is no limit to this length. Just be aware that it will consume memory.
+# You can reclaim memory used by the perf log with PERFLOG RESET.
+#
+# Default: 256
+profiling-sample-record-max-len 256
+
+# profiling-sample-record-threshold-ms use to tell the kvrocks when to record.
+#
+# Default: 100 millisecond
+profiling-sample-record-threshold-ms 100
 
 ################################## SLOW LOG ###################################
 
@@ -224,11 +230,10 @@ supervised no
 # would compact the db at 3am and 4am everyday
 compact-cron 0 3 * * *
 
-# Backup Scheduler, auto backup at schedule time
-# time expression format is the same as compact-cron
+# Bgsave scheduler, auto bgsave at schedule time
+# time expression format is the same as crontab(currently only support * and int)
 # e.g. compact-cron 0 3 * * * 0 4 * * *
-# would backup the db at 3am and 4am everyday
-# bgsave-cron 0 4 * * *
+# would bgsave the db at 3am and 4am everyday
 
 ################################ ROCKSDB #####################################
 
@@ -330,5 +335,42 @@ rocksdb.cache_index_and_filter_blocks no
 # default snappy
 rocksdb.compression snappy
 
+# If non-zero, we perform bigger reads when doing compaction. If you're
+# running RocksDB on spinning disks, you should set this to at least 2MB.
+# That way RocksDB's compaction is doing sequential instead of random reads.
+# When non-zero, we also force new_table_reader_for_compaction_inputs to
+# true.
+# 
+# Default: 2 MB
+rocksdb.compaction_readahead_size 2097152
+
+# he limited write rate to DB if soft_pending_compaction_bytes_limit or
+# level0_slowdown_writes_trigger is triggered.
+
+# If the value is 0, we will infer a value from `rater_limiter` value
+# if it is not empty, or 16MB if `rater_limiter` is empty. Note that
+# if users change the rate in `rate_limiter` after DB is opened,
+# `delayed_write_rate` won't be adjusted.
+#
+rocksdb.delayed_write_rate 0
+# If enable_pipelined_write is true, separate write thread queue is
+#  maintained for WAL write and memtable write.
+#
+#  Default: yes
+rocksdb.enable_pipelined_write yes
+
+# Soft limit on number of level-0 files. We start slowing down writes at this
+#  point. A value <0 means that no writing slow down will be triggered by
+# number of files in level-0.
+#
+# Default: 20
+rocksdb.level0_slowdown_writes_trigger 20
+
+# if not zero, dump rocksdb.stats to LOG every stats_dump_period_sec
+#
+# Default: 0
+rocksdb.stats_dump_period_sec 0
+
+
 ################################ NAMESPACE #####################################
 # namespace.test change.me