Skip to content

[KYUUBI #6926] Add SERVER_LOCAL engine share level #7013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

taylor12805
Copy link

Why are the changes needed?

As clarified in #6926, there are some scenarios user want to launch engine on each kyuubi server. SERVER_LOCAL engine share level implement this function by extracting local host address as subdomain, in which case each kyuubi server's engine is unique.

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

No

@taylor12805 taylor12805 force-pushed the share_level_server_local branch from 28d8d84 to e06de79 Compare April 3, 2025 12:09
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (1937dd9) to head (e06de79).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ain/scala/org/apache/kyuubi/engine/EngineRef.scala 0.00% 18 Missing ⚠️
...in/scala/org/apache/kyuubi/config/KyuubiConf.scala 0.00% 2 Missing ⚠️
...in/scala/org/apache/kyuubi/engine/ShareLevel.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #7013   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         694     694           
  Lines       42750   42770   +20     
  Branches     5820    5825    +5     
======================================
- Misses      42750   42770   +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants