Skip to content

[KYUUBI #7377] KSHC create database respects catalog-level warehouse#7378

Closed
maomaodev wants to merge 3 commits intoapache:masterfrom
maomaodev:kyuubi-7377
Closed

[KYUUBI #7377] KSHC create database respects catalog-level warehouse#7378
maomaodev wants to merge 3 commits intoapache:masterfrom
maomaodev:kyuubi-7377

Conversation

@maomaodev
Copy link
Copy Markdown
Contributor

@maomaodev maomaodev commented Apr 3, 2026

Why are the changes needed?

When creating a database using KSHC, the database location does not respect
spark.sql.catalog.<catalog>.hive.metastore.warehouse.dir. Instead, it always falls back to spark.sql.warehouse.dir.

How was this patch tested?

UT

Was this patch authored or co-authored using generative AI tooling?

No

@pan3793
Copy link
Copy Markdown
Member

pan3793 commented Apr 3, 2026

does table location have a similar issue? especially for creating a table under the default db

Copy link
Copy Markdown
Member

@pan3793 pan3793 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending CI.

Seems you didn't link your corp email address to your GitHub account, so your contributions won't be counted by GitHub, thus you require approval to run CI every time ...

@maomaodev
Copy link
Copy Markdown
Contributor Author

LGTM, pending CI.

Seems you didn't link your corp email address to your GitHub account, so your contributions won't be counted by GitHub, thus you require approval to run CI every time ...

Thanks for the reminder. I’ve just linked it and my corp email shows as "Verified".

@maomaodev
Copy link
Copy Markdown
Contributor Author

does table location have a similar issue? especially for creating a table under the default db

If no location is specified when creating table, a subdirectory will be automatically created under the database's location. So if the database's location is set correctly(this PR), the table's location will naturally be correct as well.

@pan3793 pan3793 added this to the v1.12.0 milestone Apr 3, 2026
@pan3793
Copy link
Copy Markdown
Member

pan3793 commented Apr 3, 2026

thanks, merging to master

@pan3793 pan3793 closed this in 3a529eb Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants