[KYUUBI #7379][2a/4] Data Agent Engine: tool system, data source, and prompt templates#7381
Closed
wangzhigang1999 wants to merge 2 commits intoapache:masterfrom
Closed
[KYUUBI #7379][2a/4] Data Agent Engine: tool system, data source, and prompt templates#7381wangzhigang1999 wants to merge 2 commits intoapache:masterfrom
wangzhigang1999 wants to merge 2 commits intoapache:masterfrom
Conversation
…iguration, and engine core
…urce, and prompt templates
github-actions
Bot
added
kind:documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 2a of 4 for the Data Agent Engine (umbrella). Stacked on #7380, please review that first.
Pure Java layer: tool system, data source abstraction, and prompt templates.
SqlQueryToolwith maxRows enforcement (hard limit 1000), output truncation (64KB), cell truncation (500 chars)ToolRegistrywith JSON schema generation for LLM function callingDataSourceFactorywith HikariCP,JdbcDialectauto-detection (Spark/SQLite/MySQL/Trino)SystemPromptBuilder— composable prompt with per-dialect templatesTest plan
SqlQueryToolTest— maxRows, truncation, NULL rendering, pipe escaping, error formatting, timeoutToolTest/ToolSchemaGeneratorTest/ToolRegistryThreadSafetyTestDataSourceFactoryAuthTest/JdbcDialectTestSystemPromptBuilderTest