Skip to content

[KSHC] Fix FileWriterFactory using the same TaskAttemptId for different task attempts#7422

Closed
maomaodev wants to merge 1 commit intoapache:masterfrom
maomaodev:kyuubi-7421
Closed

[KSHC] Fix FileWriterFactory using the same TaskAttemptId for different task attempts#7422
maomaodev wants to merge 1 commit intoapache:masterfrom
maomaodev:kyuubi-7421

Conversation

@maomaodev
Copy link
Copy Markdown
Contributor

@maomaodev maomaodev commented Apr 26, 2026

Why are the changes needed?

Port SPARK-48484 to KSHC.

Fix #7421. In the KSHC, FileWriterFactory is forked from
Spark's org.apache.spark.sql.execution.datasources.v2.FileWriterFactory. However, it still contains a
bug later fixed on the Spark side by apache/spark#46811. This PR ports that upstream fix to KSHC.

How was this patch tested?

UT

Was this patch authored or co-authored using generative AI tooling?

NO

Copy link
Copy Markdown
Member

@pan3793 pan3793 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a clear port. thanks!

@pan3793 pan3793 closed this in a99d6e0 Apr 27, 2026
pan3793 pushed a commit that referenced this pull request Apr 27, 2026
…tId for different task attempts

### Why are the changes needed?

Port SPARK-48484 to KSHC.

Fix #7421. In the KSHC, `FileWriterFactory` is forked from
Spark's `org.apache.spark.sql.execution.datasources.v2.FileWriterFactory`. However, it still contains a
bug later fixed on the Spark side by apache/spark#46811. This PR ports that upstream fix to KSHC.

### How was this patch tested?

UT

### Was this patch authored or co-authored using generative AI tooling?

NO

Closes #7422 from maomaodev/kyuubi-7421.

Closes #7422

1272f87 [lifumao] [KSHC] Fix FileWriterFactory using the same TaskAttemptId for different task attempts

Authored-by: lifumao <lifumao@tencent.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit a99d6e0)
Signed-off-by: Cheng Pan <chengpan@apache.org>
pan3793 pushed a commit that referenced this pull request Apr 27, 2026
…tId for different task attempts

### Why are the changes needed?

Port SPARK-48484 to KSHC.

Fix #7421. In the KSHC, `FileWriterFactory` is forked from
Spark's `org.apache.spark.sql.execution.datasources.v2.FileWriterFactory`. However, it still contains a
bug later fixed on the Spark side by apache/spark#46811. This PR ports that upstream fix to KSHC.

### How was this patch tested?

UT

### Was this patch authored or co-authored using generative AI tooling?

NO

Closes #7422 from maomaodev/kyuubi-7421.

Closes #7422

1272f87 [lifumao] [KSHC] Fix FileWriterFactory using the same TaskAttemptId for different task attempts

Authored-by: lifumao <lifumao@tencent.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit a99d6e0)
Signed-off-by: Cheng Pan <chengpan@apache.org>
@pan3793 pan3793 added this to the v1.10.4 milestone Apr 27, 2026
@pan3793
Copy link
Copy Markdown
Member

pan3793 commented Apr 27, 2026

merged to master/1.11.2/1.10.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] KSHC FileWriterFactory using the same TaskAttemptId for different task attempts

2 participants