Skip to content

Compute the doc range more efficiently when flushing doc block - #14447

Merged
stefanvodita merged 5 commits into
apache:mainfrom
bugmakerrrrrr:postings
Apr 23, 2025
Merged

Compute the doc range more efficiently when flushing doc block#14447
stefanvodita merged 5 commits into
apache:mainfrom
bugmakerrrrrr:postings

Conversation

@bugmakerrrrrr

Copy link
Copy Markdown
Contributor

Description

Today, we sum all the doc delta to compute the range when flushing doc block, which is equivalent to lastDocID - level0LastDocID.

@stefanvodita stefanvodita left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might still apply to Lucene103PostingsWriter. Should we rebase?

@jainankitk

Copy link
Copy Markdown
Contributor

Thanks for updating the PR to include Lucene103PostingsWriter. LGTM!

@stefanvodita stefanvodita left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the 10.3 postings writer! I'm happy to merge that change, but I would rather not mix in the 10.1 change since that release has already gone out and we're unlikely to release a follow-up unless we find serious bugs.

Could you also add an entry under 10.3 in CHANGES.txt?

@stefanvodita

Copy link
Copy Markdown
Contributor

Sorry, I don't know if I was clear enough. I was asking if we can also revert the change to Lucene101PostingsWriter and only change Lucene103PostingsWriter this time.

Thanks for adding the changelog entry!

@bugmakerrrrrr

Copy link
Copy Markdown
Contributor Author

Sorry, I don't know if I was clear enough. I was asking if we can also revert the change to Lucene101PostingsWriter and only change Lucene103PostingsWriter this time.

Thanks for adding the changelog entry!

My fault, I forgot to revert.

@stefanvodita stefanvodita left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bugmakerrrrrr!

@stefanvodita
stefanvodita merged commit 672f123 into apache:main Apr 23, 2025
@gf2121 gf2121 added this to the 10.3.0 milestone Apr 23, 2025
jpountz pushed a commit to jpountz/lucene that referenced this pull request Apr 24, 2025
gf2121 pushed a commit to gf2121/lucene that referenced this pull request Apr 29, 2025
gf2121 pushed a commit to gf2121/lucene that referenced this pull request Apr 29, 2025
gf2121 pushed a commit to gf2121/lucene that referenced this pull request May 7, 2025
gf2121 added a commit that referenced this pull request May 9, 2025
* A specialized Trie for Block Tree Index (#14333)

* Fix OOM of TestTrie (#14488)

* Compute the doc range more efficiently when flushing doc block (#14447)

* Fix TestForTooMuchCloning (#14547)

* Fix tests: too many calls to IndexInput.clone during merging (#14595)

* Simplify rootCodeFp (#14596)

---------

Co-authored-by: panguixin <panguixin@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants