Fix too many documents collected when only bool-filter condition is present - #14757
Merged
Conversation
github-project-automation
Bot
moved this to Open
in OpenSearch Lucene & Core Performance Tracking
Contributor
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
kkewwei
changed the title
jpountz
approved these changes
Jun 5, 2025
github-project-automation
Bot
moved this from Open
to Merged
in OpenSearch Lucene & Core Performance Tracking
Contributor
|
Thank you! |
jpountz
pushed a commit
that referenced
this pull request
Jun 5, 2025
Contributor
|
FYI I backported to branch_10x so that it's included in 10.3. |
Contributor
|
The changes entry needs to be moved. |
Contributor
Author
@uschindler Kindly advise whether it is should be placed under the "Improvements" or |
Contributor
|
It's only about the version number. It was a message for @jpountz who merged this. |
Contributor
|
He did that already. |
Contributor
|
Yup, I didn't want to bother @kkewwei with this so I did it myself, it's easy enough. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
New logic is consistent with the implementation of 9.8
https://github.com/apache/lucene/blob/releases/lucene/9.8.0/lucene/core/src/java/org/apache/lucene/search/Boolean2ScorerSupplier.java#L112
Closes: #14755