Improve sorting logic in NeighborArray and add test for stable order#16320
Open
rajat315315 wants to merge 5 commits into
Open
Improve sorting logic in NeighborArray and add test for stable order#16320rajat315315 wants to merge 5 commits into
rajat315315 wants to merge 5 commits into
Conversation
…with equal scores
…with equal scores
Author
Benchmark ResultsI ran Test Parameters:
Hardware/Environment:
Conclusion: |
Contributor
|
Can you explain the search speedup? I don't see how any improvements in this area can affect search given that we only use NeighborArray while indexing. This is making me doubt all the results reported here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16321
Description
The legacy sorting logic in NeighborArray below takes
O(N^2)in worst case, as it is a form of insertion sort and pushes/copies the rest of the array towards the end for each uncheckedIndex.The solution I'm proposing takes
O(N)time complexity andO(N)space complexity.