Added AsSpan() and AsMemory() methods to ICharTermAttribute, CharsRef, and BytesRef (#1192)

* .build/dependencies.props: Added dependency on Microsoft.Bcl.Memory for Index/Range and Utf8 support on .NET Framework and .NET Standard 2.0. Bumped System.Memory to 4.6.3 (Required by Microsoft.Bcl.Memory).

* Added Lucene.Net.MemoryExtensions class with support for AsSpan() and AsMemory() overloads for ICharTermAttribute.

* Lucene.Net.Util.CharsRef: Added AsSpan(), AsMemory(), ctor, CopyChars(), and Append() methods to support System.Memory types.

* Lucene.Net.Util.BytesRef: Added AsSpan(), AsMemory(), ctor, CopyChars(), and Append() methods to support System.Memory types.

* Lucene.Net.Tests/Support/TestMemoryExtensions.cs: Added LuceneNetAttribute and links to the sources the file is based on.

Author: NightOwl888

.build/dependencies.props

@@ -43,6 +43,7 @@
     <LuceneNetCodeAnalysisDevPackageVersion>1.0.0-alpha.6</LuceneNetCodeAnalysisDevPackageVersion>
     <MicrosoftAspNetCoreHttpAbstractionsPackageVersion>2.3.0</MicrosoftAspNetCoreHttpAbstractionsPackageVersion>
     <MicrosoftAspNetCoreTestHostPackageVersion>8.0.19</MicrosoftAspNetCoreTestHostPackageVersion>
+    <MicrosoftBclMemoryPackageVersion>10.0.0-rc.1.25451.107</MicrosoftBclMemoryPackageVersion>
     <MicrosoftCodeAnalysisAnalyzersPackageVersion>2.9.8</MicrosoftCodeAnalysisAnalyzersPackageVersion>
     <MicrosoftCodeAnalysisCSharpPackageVersion>2.6.1</MicrosoftCodeAnalysisCSharpPackageVersion>
     <MicrosoftCodeAnalysisCSharpWorkspacesPackageVersion>$(MicrosoftCodeAnalysisCSharpPackageVersion)</MicrosoftCodeAnalysisCSharpWorkspacesPackageVersion>
@@ -70,7 +71,7 @@
     <RandomizedTestingGeneratorsPackageVersion>2.7.8</RandomizedTestingGeneratorsPackageVersion>
     <SharpZipLibPackageVersion>1.4.2</SharpZipLibPackageVersion>
     <Spatial4nPackageVersion>0.4.1.1</Spatial4nPackageVersion>
-    <SystemMemoryPackageVersion>4.5.5</SystemMemoryPackageVersion>
+    <SystemMemoryPackageVersion>4.6.3</SystemMemoryPackageVersion>
     <SystemNetHttpPackageVersion>4.3.4</SystemNetHttpPackageVersion>
     <SystemReflectionEmitPackageVersion>4.3.0</SystemReflectionEmitPackageVersion>
     <SystemReflectionEmitILGenerationPackageVersion>4.3.0</SystemReflectionEmitILGenerationPackageVersion>

Directory.Build.targets

@@ -63,6 +63,7 @@
   <!-- Features in .NET 5.x, .NET 6.x, .NET 7.x, .NET 8.x, and .NET 9.x only -->
   <PropertyGroup Condition=" $(TargetFramework.StartsWith('net5.')) Or $(TargetFramework.StartsWith('net6.')) Or $(TargetFramework.StartsWith('net7.')) Or $(TargetFramework.StartsWith('net8.')) Or $(TargetFramework.StartsWith('net9.')) ">
 
+    <DefineConstants>$(DefineConstants);FEATURE_MEMORYMARSHAL_GETARRAYDATAREFERENCE</DefineConstants>
     <DefineConstants>$(DefineConstants);FEATURE_READONLYSET</DefineConstants>
 
   </PropertyGroup>
@@ -91,6 +92,7 @@
     <DefineConstants>$(DefineConstants);FEATURE_ARRAY_FILL</DefineConstants>
     <DefineConstants>$(DefineConstants);FEATURE_CONDITIONALWEAKTABLE_ENUMERATOR</DefineConstants>
     <DefineConstants>$(DefineConstants);FEATURE_CONDITIONALWEAKTABLE_ADDORUPDATE</DefineConstants>
+    <DefineConstants>$(DefineConstants);FEATURE_MEMORYMARSHAL_CREATEREADONLYSPAN</DefineConstants>
     <DefineConstants>$(DefineConstants);FEATURE_NUMBER_PARSE_READONLYSPAN</DefineConstants>
     <DefineConstants>$(DefineConstants);FEATURE_STREAM_READ_SPAN</DefineConstants>
     <DefineConstants>$(DefineConstants);FEATURE_STRINGBUILDER_APPEND_READONLYSPAN</DefineConstants>

src/Lucene.Net.TestFramework/Support/TestFramework/Assert.cs

@@ -1164,6 +1164,18 @@ public static Exception Throws(Type expectedExceptionType, Action action, string
             return _NUnit.Assert.Throws(expectedExceptionType, () => action(), message, args);
         }
 
+        [DebuggerStepThrough]
+        [MethodImpl(MethodImplOptions.AggressiveInlining)]
+        public static T Throws<T>(string expectedParamName, Action action)
+            where T : ArgumentException
+        {
+            T exception = _NUnit.Assert.Throws<T>(() => action());
+
+            _NUnit.Assert.AreEqual(expectedParamName, exception.ParamName);
+
+            return exception;
+        }
+
         [DebuggerStepThrough]
         public static Exception ThrowsFileAlreadyExistsException(string filePath, Action action)
         {

src/Lucene.Net.Tests._J-S/Lucene.Net.Tests._J-S.csproj

@@ -26,6 +26,7 @@
   <PropertyGroup>
     <AssemblyTitle>Lucene.Net.Tests._J-S</AssemblyTitle>
     <RootNamespace>Lucene.Net</RootNamespace>
+    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>
 
   <ItemGroup>

src/Lucene.Net.Tests._T-Z/Lucene.Net.Tests._T-Z.csproj

@@ -26,11 +26,13 @@
   <PropertyGroup>
     <AssemblyTitle>Lucene.Net.Tests._T-Z</AssemblyTitle>
     <RootNamespace>Lucene.Net</RootNamespace>
+    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>
 
   <ItemGroup>
     <Compile Include="..\Lucene.Net.Tests\Properties\AssemblyInfo.cs" Link="Properties\AssemblyInfo.cs" />
     <Compile Include="..\Lucene.Net.Tests\Util\**\*.cs" LinkBase="Util" />
+    <Compile Include="..\Lucene.Net.Tests\Support\TestHelpers.cs" />
     <Compile Remove="..\Lucene.Net.Tests\Util\JunitCompat\**\*;..\Lucene.Net.Tests\Util\TestMaxFailuresRule.cs" />
   </ItemGroup>