Overhaul MMapDirectory with MemoryMappedViewAccessor, #1013, #1151 - #1267

Closed

paulirwin wants to merge 24 commits into

apache:masterfrom

paulirwin:issue/1013-mmap-redesign

Commits on Jun 16, 2026

Overhaul MMapDirectory with MemoryMappedViewAccessor, #1013, #1151
paulirwin
committed
88ea6a0
Fix namespace and add more unit tests
paulirwin
committed
6c7bb10
Fix Copilot's PR feedback
paulirwin
committed
9a9775f
PR feedback and code cleanup
paulirwin
committed
0c8ace9
Refactor View into Chunk support
paulirwin
committed
3c7a11b
Address PR feedback: nest MMapIndexInput, share MemoryMappedFile across slices

paulirwin
and
claude
committed
43b26a4
Code cleanup and fix field naming error
paulirwin
committed
620bbe7
Document why MapChunks doesn't allocate a trailing zero-length sentinel

paulirwin
and
claude
committed
6e43fb5
Fix Xml doc comment reference
paulirwin
committed
b973ee4
Remove per-file mapping cache for upstream Java parity

paulirwin
and
claude
committed
598d5db
Switch MMapIndexInput to direct-pointer fast path with cached chunk pointers

paulirwin
and
claude
committed
20c6568
MMapDirectory follow-up review fixes

paulirwin
and
claude
committed
911cf35
Pass capacity: 0 to MemoryMappedFile.CreateFromFile, drop the #1090 retry loop

paulirwin
and
claude
committed
6fecb81
Open the file with FileShare.ReadWrite | Delete on Windows for delete-while-mapped

paulirwin
and
claude
committed
7e4c8b4
Use string interpolation
paulirwin
committed
12b8c22
Capitalize BasePtr and Length
paulirwin
committed
31c9d33
Improve exception handling
paulirwin
committed
7f69b7c
Inline ReadIntXX slow path; split ReadBytes into ref-byte core

paulirwin
and
claude
committed
a7e081b
Allow MMapDirectory+Chunk.BasePtr/Length in private-field-name scan

paulirwin
and
claude
committed
db868fa
Fix capacity race on .NET Framework
paulirwin
committed
f5892ae
Add comments about FileShare modes
paulirwin
committed
f9a73c1
Address PR #1267 review: FileStream ownership + exception-handling cleanup

paulirwin
and
claude
committed
3a781a7
Add MockDirectoryWrapper leak-gate test for MMap slice/clone paths

paulirwin
and
claude
committed
fb6382f
Reclaim MemoryMappedViewAccessor stranded by cross-thread Dispose (#1013)

paulirwin
and
claude
committed
f9b634a

Navigation Menu

Uh oh!

Overhaul MMapDirectory with MemoryMappedViewAccessor, #1013, #1151 - #1267

Overhaul MMapDirectory with MemoryMappedViewAccessor, #1013, #1151#1267
paulirwin wants to merge 24 commits into
apache:masterfrom
paulirwin:issue/1013-mmap-redesign

Commits on Jun 16, 2026

Overhaul MMapDirectory with MemoryMappedViewAccessor, #1013, #1151

Fix namespace and add more unit tests

Fix Copilot's PR feedback

PR feedback and code cleanup

Refactor View into Chunk support

Address PR feedback: nest MMapIndexInput, share MemoryMappedFile across slices

Code cleanup and fix field naming error

Document why MapChunks doesn't allocate a trailing zero-length sentinel

Fix Xml doc comment reference

Remove per-file mapping cache for upstream Java parity

Switch MMapIndexInput to direct-pointer fast path with cached chunk pointers

MMapDirectory follow-up review fixes

Pass capacity: 0 to MemoryMappedFile.CreateFromFile, drop the #1090 retry loop

Open the file with FileShare.ReadWrite | Delete on Windows for delete-while-mapped

Use string interpolation

Capitalize BasePtr and Length

Improve exception handling

Inline ReadIntXX slow path; split ReadBytes into ref-byte core

Allow MMapDirectory+Chunk.BasePtr/Length in private-field-name scan

Fix capacity race on .NET Framework

Add comments about FileShare modes

Address PR #1267 review: FileStream ownership + exception-handling cleanup

Add MockDirectoryWrapper leak-gate test for MMap slice/clone paths

Reclaim MemoryMappedViewAccessor stranded by cross-thread Dispose (#1013)