SWEEP: Upgraded to the navigable APIs on `SortedSet<T>` and `SortedDictionary<TKey, TValue>` - #1268

Merged

NightOwl888 merged 13 commits into

apache:masterfrom

NightOwl888:feature/navigable-apis

Apr 23, 2026

Commits on Apr 20, 2026

Lucene.Net.Codecs.SimpleText.SimpleTextTermVectorsReader.SimpleTVTermsEnum: Use GetViewAfter() to match the upstream code.
NightOwl888
committed
4625728
Lucene.Net.Codecs.Compressing.CompressingTermVectorsWriter: Use SortedSet<T>.TryGetLast() rather than Max, since the latter is obsolete. Fixed implementation to throw InvalidOperationException in t…
NightOwl888
committed
232ebcb
Lucene.Net.Grouping.AbstractFirstPassGroupingCollector: Removed LINQ calls and replaced them with navigable collection APIs, which will reduce allocations.
NightOwl888
committed
6061187
Lucene.Net.Grouping.AbstractGrouFacetCollector: Converted calls to the obsolete SortedSet<T>.Max property to calls to RemoveLast() and TryGetLast().
NightOwl888
committed
771d50e
Lucene.Net.Grouping.SearchGroup.GroupMerger<T>: Replaced calls to the obsolete SortedSet<T> properties Min and Max with RemoveFirst() and RemoveLast()
NightOwl888
committed
f8ddc5a
Lucene.Net.Search.Suggest.Analyzing.BlendedInfixSuggester: Replaced call to obsolete SortedSet<T>.Min property with TryGetFirst().
NightOwl888
committed
f28876e
Lucene.Net.Util.Fst.Util: Replaced calls to obsolete SortedSet<T> properties Min and Max with RemoveFirst(), RemoveLast() and TryGetLast()
NightOwl888
committed
a3fe697
Lucene.Net.Analysis.MockCharFilter: Replaced call to obsolete SortedSet<T>.TryGetPredecessor() overload with the new overload.
NightOwl888
committed
e7c59b3
Lucene.Net.Search.PostingsHighlight.PostingsHighlighter: Replaced call to obsolete SortedSet<T>.GetViewBetween() method and replaced with GetView().
NightOwl888
committed
c50cc40
Lucene.Net.Codecs.RAMOnly.RamOnlyPostingsFormat.RAMTermsEnum: Changed implementation to use GetViewAfter() and TryGetLast() of SortedDictionary<TKey, TValue> rather than resorting to LINQ calls.
NightOwl888
committed
fafb5fd
Lucene.Net.Codecs.Lucene40.Lucene40DocValuesWriter: Added comment defending the use of LINQ for this specific case rather than using GetViewBefore().
NightOwl888
committed
3aba426

Commits on Apr 23, 2026

Update src/Lucene.Net.Grouping/AbstractFirstPassGroupingCollector.cs

NightOwl888
and
paulirwin
authored
95df1a2
Update src/Lucene.Net.Grouping/AbstractGroupFacetCollector.cs

NightOwl888
and
paulirwin
authored
3504075

Navigation Menu

Uh oh!

SWEEP: Upgraded to the navigable APIs on `SortedSet<T>` and `SortedDictionary<TKey, TValue>` - #1268

SWEEP: Upgraded to the navigable APIs on `SortedSet<T>` and `SortedDictionary<TKey, TValue>`#1268
NightOwl888 merged 13 commits into
apache:masterfrom
NightOwl888:feature/navigable-apis

Commits on Apr 20, 2026

Lucene.Net.Codecs.SimpleText.SimpleTextTermVectorsReader.SimpleTVTermsEnum: Use GetViewAfter() to match the upstream code.

Lucene.Net.Codecs.Compressing.CompressingTermVectorsWriter: Use SortedSet<T>.TryGetLast() rather than Max, since the latter is obsolete. Fixed implementation to throw InvalidOperationException in t…

Lucene.Net.Grouping.AbstractFirstPassGroupingCollector: Removed LINQ calls and replaced them with navigable collection APIs, which will reduce allocations.

Lucene.Net.Grouping.AbstractGrouFacetCollector: Converted calls to the obsolete SortedSet<T>.Max property to calls to RemoveLast() and TryGetLast().

Lucene.Net.Grouping.SearchGroup.GroupMerger<T>: Replaced calls to the obsolete SortedSet<T> properties Min and Max with RemoveFirst() and RemoveLast()

Lucene.Net.Search.Suggest.Analyzing.BlendedInfixSuggester: Replaced call to obsolete SortedSet<T>.Min property with TryGetFirst().

Lucene.Net.Util.Fst.Util: Replaced calls to obsolete SortedSet<T> properties Min and Max with RemoveFirst(), RemoveLast() and TryGetLast()

Lucene.Net.Analysis.MockCharFilter: Replaced call to obsolete SortedSet<T>.TryGetPredecessor() overload with the new overload.

Lucene.Net.Search.PostingsHighlight.PostingsHighlighter: Replaced call to obsolete SortedSet<T>.GetViewBetween() method and replaced with GetView().

Lucene.Net.Codecs.RAMOnly.RamOnlyPostingsFormat.RAMTermsEnum: Changed implementation to use GetViewAfter() and TryGetLast() of SortedDictionary<TKey, TValue> rather than resorting to LINQ calls.

Lucene.Net.Codecs.Lucene40.Lucene40DocValuesWriter: Added comment defending the use of LINQ for this specific case rather than using GetViewBefore().

Commits on Apr 23, 2026

Update src/Lucene.Net.Grouping/AbstractFirstPassGroupingCollector.cs

Update src/Lucene.Net.Grouping/AbstractGroupFacetCollector.cs