[CI] Switch pre-commit to use ASF approved prek-action - #1318
Merged
Conversation
paulirwin
approved these changes
Jun 10, 2026
paulirwin
left a comment
paulirwin
left a comment
Contributor
There was a problem hiding this comment.
This looks good, approved. I like this for several reasons:
- Removes a lot of noise from the workflow file
- Doesn't require installing Python
- Uses an ASF-approved action, pinned to a SHA
- It's already in use at another Apache project
- Works well with our existing pre-commit rules
- ... and WOW is it fast! Running prek locally is anywhere from 1.5-2.6x faster in initial testing.
Thanks for doing this!
paulirwin
force-pushed
the
switch-to-prek-action
branch
from
June 10, 2026 14:59
b1b773a to
bd11b08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to use the ASF approved prek-action:
https://github.com/apache/infrastructure-actions/blob/437608c5893288af177de21bb7e7b735a548ee26/approved_patterns.yml#L213
https://prek.j178.dev/
refs apache/shiro#2705
https://prek.j178.dev/#who-is-using-prek