misc: fix typos - #1404
Merged
Merged
Conversation
NightOwl888
requested changes
Jul 6, 2026
NightOwl888
left a comment
NightOwl888
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR.
Looks good except for the one test condition change. But being that the intent of the test hasn't changed and the test passes, I think this is fine as long as we add a comment to explain why we diverged from Lucene. Please see the inline comment.
Co-authored-by: Paul Irwin <paulirwin@gmail.com>
NightOwl888
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General spelling clean up