Skip to content

Port Lucene 4.8.1 fixes for AnalyzingSuggester, OfflineSorter, and SpecialOperations, #1381#1422

Open
paulirwin wants to merge 5 commits into
apache:masterfrom
paulirwin:issue/1381-batch-4
Open

Port Lucene 4.8.1 fixes for AnalyzingSuggester, OfflineSorter, and SpecialOperations, #1381#1422
paulirwin wants to merge 5 commits into
apache:masterfrom
paulirwin:issue/1381-batch-4

Conversation

@paulirwin

Copy link
Copy Markdown
Contributor
  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Backport Lucene 4.8.1 fixes for AnalyzingSuggester, OfflineSorter, and SpecialOperations

Partial #1381 (Batch 4)

Description

This PR backports commits 8c4e8268181 (LUCENE-5628) and 9d10d6f92cc (LUCENE-5660) from Lucene 4.8.1. This has the added benefit of re-enabling the commented-out TestTooLongSuggestion test!

Batch 1 (PR #1413) incorrectly included the OfflineSorter change; that is actually part of LUCENE-5660; it was just difficult to tell that since the commit message did not mention a JIRA number. I'm going to remove that from that PR since it is necessary here for the test to pass.

@paulirwin
paulirwin requested a review from NightOwl888 July 12, 2026 21:13
@paulirwin paulirwin added the notes:bug-fix Contains a fix for a bug label Jul 12, 2026
@paulirwin

Copy link
Copy Markdown
Contributor Author

I updated the API consistency type scanner to exclude private classes due to the PathNode failure there. These are not part of the API surface and thus should not be considered for these rules. This will help us avoid having to add other similar exclusions manually.

@paulirwin paulirwin changed the title Backport Lucene 4.8.1 fixes for AnalyzingSuggester, OfflineSorter, and SpecialOperations, #1381 Port Lucene 4.8.1 fixes for AnalyzingSuggester, OfflineSorter, and SpecialOperations, #1381 Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

notes:bug-fix Contains a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant