Port Lucene 4.8.1 fixes for AnalyzingSuggester, OfflineSorter, and SpecialOperations, #1381#1422
Open
paulirwin wants to merge 5 commits into
Open
Port Lucene 4.8.1 fixes for AnalyzingSuggester, OfflineSorter, and SpecialOperations, #1381#1422paulirwin wants to merge 5 commits into
paulirwin wants to merge 5 commits into
Conversation
19 tasks
4 tasks
Contributor
Author
|
I updated the API consistency type scanner to exclude private classes due to the PathNode failure there. These are not part of the API surface and thus should not be considered for these rules. This will help us avoid having to add other similar exclusions manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport Lucene 4.8.1 fixes for AnalyzingSuggester, OfflineSorter, and SpecialOperations
Partial #1381 (Batch 4)
Description
This PR backports commits 8c4e8268181 (LUCENE-5628) and 9d10d6f92cc (LUCENE-5660) from Lucene 4.8.1. This has the added benefit of re-enabling the commented-out TestTooLongSuggestion test!
Batch 1 (PR #1413) incorrectly included the OfflineSorter change; that is actually part of LUCENE-5660; it was just difficult to tell that since the commit message did not mention a JIRA number. I'm going to remove that from that PR since it is necessary here for the test to pass.