Remove outdated System.Text.Json pinned reference - #1436
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the explicit, centrally-versioned System.Text.Json package pin that was previously added to override a vulnerable transitive dependency in the OpenNLP analysis module, aligning dependency management with the current .NET (net8/net10) targeting and updated dependency stack (notably in combination with #1435).
Changes:
- Removed the direct
System.Text.JsonPackageReferenceoverride fromLucene.Net.Analysis.OpenNLP.csproj. - Removed the now-unused
SystemTextJsonPackageVersionproperty from.build/dependencies.props.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Lucene.Net.Analysis.OpenNLP/Lucene.Net.Analysis.OpenNLP.csproj | Drops the explicit System.Text.Json package pin/override previously used to address a vulnerable transitive dependency. |
| .build/dependencies.props | Removes the SystemTextJsonPackageVersion property since it’s no longer referenced. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove outdated System.Text.Json pinned reference
Description
This was necessary at one point in the past to resolve a vulnerable package warning; it is no longer necessary since STJ ships with .NET 8/10 targeted by the OpenNLP library. Combined with #1435, there are now zero warnings when building the solution again.