Skip to content

Remove outdated System.Text.Json pinned reference - #1436

Merged
paulirwin merged 1 commit into
apache:masterfrom
paulirwin:bugfix/system-text-json-NU1510
Aug 9, 2026
Merged

Remove outdated System.Text.Json pinned reference#1436
paulirwin merged 1 commit into
apache:masterfrom
paulirwin:bugfix/system-text-json-NU1510

Conversation

@paulirwin

Copy link
Copy Markdown
Contributor
  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Remove outdated System.Text.Json pinned reference

Description

This was necessary at one point in the past to resolve a vulnerable package warning; it is no longer necessary since STJ ships with .NET 8/10 targeted by the OpenNLP library. Combined with #1435, there are now zero warnings when building the solution again.

@paulirwin paulirwin added the notes:bug-fix Contains a fix for a bug label Aug 9, 2026
@paulirwin
paulirwin requested a lite review from Copilot August 9, 2026 21:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the explicit, centrally-versioned System.Text.Json package pin that was previously added to override a vulnerable transitive dependency in the OpenNLP analysis module, aligning dependency management with the current .NET (net8/net10) targeting and updated dependency stack (notably in combination with #1435).

Changes:

  • Removed the direct System.Text.Json PackageReference override from Lucene.Net.Analysis.OpenNLP.csproj.
  • Removed the now-unused SystemTextJsonPackageVersion property from .build/dependencies.props.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Lucene.Net.Analysis.OpenNLP/Lucene.Net.Analysis.OpenNLP.csproj Drops the explicit System.Text.Json package pin/override previously used to address a vulnerable transitive dependency.
.build/dependencies.props Removes the SystemTextJsonPackageVersion property since it’s no longer referenced.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@paulirwin
paulirwin merged commit 567cec6 into apache:master Aug 9, 2026
211 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

notes:bug-fix Contains a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants