Fix/dynamic cuda encoding method list#1100
Open
SuyashParmar wants to merge 2 commits intoapache:mainfrom
Open
Conversation
SuyashParmar
requested review from
400Ping,
guan404ming and
ryankert01
as code owners
Contributor
Author
|
@ryankert01 can you pls check the updates ? |
viiccwen
reviewed
Feb 28, 2026
Comment on lines
+61
to
+72
| fn format_supported_cuda_encoding_methods() -> String { | ||
| let quoted: Vec<String> = CUDA_ENCODING_METHODS | ||
| .iter() | ||
| .map(|method| format!("'{}'", method)) | ||
| .collect(); | ||
| let len = quoted.len(); | ||
| if len == 1 { | ||
| return quoted[0].clone(); | ||
| } | ||
| format!("{}, or {}", quoted[..len - 1].join(", "), quoted[len - 1]) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
The intent of this helper function can be more clean, manual length handling and clone is unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed :
Added CUDA_ENCODING_METHODS constant in pytorch.rs
Added helper format_supported_cuda_encoding_methods() to build the error message dynamically.
Updated unknown-encoding error path to use the dynamic method list.