This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
MSHARED-341: New API to support to analyze artifact's dependencies #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Anybody take a look at this pull request? It's trying to analyze transitive dependencies also. Simple enhancement for current API. Regards |
|
@wangyf2010 I am willing to merge this. Can you check this against master wether code has change. Additionally, do have have a good example what the benefit is? Moreover, how does it affect clients using the current API? I am totally unaware. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need new API to analyze artifact's dependencies too.
Later could leverage this API to enhance maven-dependency-plugin to analyze project's transitive dependencies and provide more intensive analyzing report.
It could help users:
not only find out "unused but declared dependencies" for current project. It could analyze others domain's dependencies also.
Reason from Real World:
In real world, it's hard to drive others domain's to optimize their dependencies. But with this report, any developers could start to drive others domains to optimize their dependency hierarchies.
This API will leverage actual analyzing logic to ProjectDependencyAnalyzer.
Analyze result is the same to ProjectDependencyAnalyzer.