Update Maven 3 xsd to reflect required elements

[slachiewicz]

Regenerated with Modello 2.7 that contains codehaus-plexus/modello#528 based on maven-3.10.x branch

[Copilot]

Pull request overview

Regenerates the Maven POM 4.0.0 XML Schema (maven-4.0.0.xsd) using Modello 2.7.0 (based on the maven-3.10.x branch) to update schema structure/documentation and element occurrence constraints.

Changes:

• Regenerated maven-4.0.0.xsd with Modello 2.7.0 (header + widespread formatting changes).
• Updated a number of minOccurs declarations (making several elements required).
• Updated documentation text (e.g., interpolation docs mentioning ${project.rootDirectory}).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Build/sourceDirectory is now required (minOccurs removed), but the build source directory has a well-known default (and is optional in POMs). Requiring it will invalidate most existing POMs. Consider restoring minOccurs="0" for this element (and keep the default behavior documented).

Suggested change

	<xs:element name="sourceDirectory" type="xs:string">
	<xs:element minOccurs="0" name="sourceDirectory" type="xs:string">

[Copilot]

Build/testSourceDirectory is now required, but it is optional in Maven (defaulting to src/test/java). Requiring it will cause many valid POMs to fail XSD validation. Consider restoring minOccurs="0" for this element.

Suggested change

	<xs:element name="testSourceDirectory" type="xs:string">
	<xs:element minOccurs="0" name="testSourceDirectory" type="xs:string">

[Copilot]

Build/scriptSourceDirectory is now required, but this directory is optional in Maven (with a documented default). Making it required will break schema validation for projects that don’t define it. Consider restoring minOccurs="0" for this element.

Suggested change

	<xs:element name="scriptSourceDirectory" type="xs:string">
	<xs:element minOccurs="0" name="scriptSourceDirectory" type="xs:string">

[slawekjaranowski]

Looks like copilot comments are right ...

We should review maven.mdo again ...

[gnodet]

Agreed, those changes look wrong. Are they caused by modello upgrade? Is that a regression or a "bug fix"?

[slawekjaranowski]

Agreed, those changes look wrong. Are they caused by modello upgrade? Is that a regression or a "bug fix"?

fix in modello 2.6.0

• Fix XSD generator to respect required field attribute codehaus-plexus/modello#528

but show as the we required some of fields which should not be required ...

[slawekjaranowski]

• Required model fields vs validation maven#11979

[slawekjaranowski]

next try with:

• Remove redundant required attributes from Maven model maven#11985

[slawekjaranowski]

@Copilot check again

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

There is a typo in the documentation text: "aretifactId" should be "artifactId" (and the sentence reads awkwardly without an article, e.g., "the artifactId").

Suggested change

	<xs:documentation source="description">The full name of the project. If not specified aretifactId will be used.</xs:documentation>
	<xs:documentation source="description">The full name of the project. If not specified, the artifactId will be used.</xs:documentation>

[Copilot]

Profile now requires an <id> element but still declares default="default". If the element is required, the default attribute is redundant/misleading; either remove the default or keep the element optional if a default value is intended.

Suggested change

	<xs:element name="id" type="xs:string" default="default">
	<xs:element name="id" type="xs:string">

[slawekjaranowski]

@copilot close - resolve conversations which was fixed