Introduce validation control#12520
Open
cstamas wants to merge 2 commits into
Open
Conversation
This config is sourced from Java System Properties, as there is no access to session. Enables validation level in Maven Resolver validator.
cstamas
marked this pull request as ready for review
July 22, 2026 13:12
gnodet
approved these changes
Jul 24, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
There was a problem hiding this comment.
Code Review
Clean, well-scoped escape-hatch feature introducing configurable validation levels (maven.resolver.validation) for the Maven Resolver validator. The three levels (DEFAULT, MILD, OFF) are well-documented in Constants.java and accurately reflect the implementation. Default behavior is preserved, singleton pattern for validator instances is efficient, and the @since 3.10.0 tag is consistent with existing convention.
Two minor notes (non-blocking):
- No unit tests for the new
MavenValidator(boolean)constructor behavior — while the feature is simple, tests covering the three validation levels would improve confidence. - The
ValidationLevelenum could be made package-private sinceMavenValidatorFactoryis in theimplmodule.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
gnodet
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables validation level choice in Maven Resolver validator.
This change should go to every Maven version having
MavenValidator(3.10, 4.0 and 4.1).Related: apache/maven-resolver#2007