[Backport 4.0.x] Fix filterByScope to expand lifecycle scopes for build ordering - #13070
Merged
Conversation
The concurrent builder's filterByScope used exact string matching between the lifecycle dependency scope (e.g. "compile") and the declared artifact scope. This meant a provided-scope reactor dependency was not ordered before the consumer's compile phase, since "compile" != "provided". Expand the lifecycle scope to match all artifact scopes that contribute to it: - "compile" -> compile, provided, system (+ null defaults to compile) - "runtime" -> compile, runtime (+ null) - "test" -> all scopes - "test-only" -> test only This ensures provided/system-scope reactor projects are built before downstream modules that need them for compilation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12680 to
maven-4.0.x.Summary
The concurrent builder's
filterByScopeused exact string matching between the lifecycle dependency scope (e.g."compile") and the declared artifact scope in the model. This meant aprovided-scope reactor dependency was not ordered before the consumer's compile phase, since"compile" != "provided".Fix
Expand the lifecycle scope to match all artifact scopes that contribute to it for build ordering:
"compile"→ compile, provided, system (+ null defaults to compile)"runtime"→ compile, runtime (+ null)"test"→ all scopes"test-only"→ test onlyCherry-picked cleanly from master (
7f5d22e9ee).