Fix #13092: tokenize quoted --define in maven.config - #13093
Open
kalayciburak wants to merge 1 commit into
Open
Conversation
Each maven.config line was passed to Commons CLI as a single argv token, so --define 'revision=...' was treated as an unrecognized option while -Drevision=... and the equivalent CLI tokens worked. Split each config line on unquoted whitespace, stripping quotes, before parsing. Signed-off-by: Burak KALAYCI <kalayciburak1996@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.mvn/maven.configtreated each line as a single argv token. That made--define 'revision=1.0-SNAPSHOT'an unrecognized option, while the same tokens on the CLI and-Drevision=...in the same file both worked.Each config line is now split on unquoted whitespace (quotes are stripped), matching how the shell tokenizes the equivalent CLI.
Test Plan
mvn -pl impl/maven-cli -Dtest=MavenParserTest,CommonsCliOptionsTest test— 6/0mvn -pl compat/maven-embedder -Dtest=CleanArgumentTest,MavenCliTest test— 51/0 (1 skipped)Fixes #13092