Implement getOutputPath() in the site IT plugin - #13096
Merged
Merged
Conversation
Maven Reporting API 4.0.0 deprecated getOutputName(); it stays as a delegate because the interface still declares it abstract.
|
@slachiewicz Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InfoReportinmaven-it-plugin-siteimplements onlygetOutputName(), which Maven Reporting API 4.0.0 deprecated in favour ofgetOutputPath(). The IT plugin already compiles against 4.0.0, so it can use the current method;getOutputName()stays as a deprecated delegate because the interface still declares it abstract.No behaviour change —
infoeither way. Last of a sweep that has moved the estate's report implementations ontogetOutputPath().Verified:
mvn -f its/core-it-support/core-it-plugins/maven-it-plugin-site/pom.xml compile→ BUILD SUCCESS. I did not run the core ITs.Targets
maven-4.0.xfirst; the same change formasterfollows once this lands.This change was created with AI assistance.