newt: If no dependencies are present, still try to build #595
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependencies - This only happens when `newt` is used to build a standalone project without any repos or dependencies listed, everything local
vrahane
force-pushed
the
vipul/debug_build
branch
from
54e26d8 to
38c0eb4
Compare
| if stages == nil { | ||
| util.FmtNewtError("Cannot resolve sysinit order: no stages defined.") | ||
| return []stage.StageFunc{}, nil | ||
| } |
There was a problem hiding this comment.
I think this can only happen if sfs is empty so you can basically check that at the very beginning of the function. Also no need to emit warning.
| return r.localPath | ||
| } else { | ||
| return "" | ||
| } |
There was a problem hiding this comment.
This will "hide" all issues where Path() is called unintentionally on nil object, so better to actually explicitly handle this on caller side. Of course as long as there is some valid case in which we can actually have nil repo that we should handle properly, not sure when this could happen though tbh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.