EATT manual connection & multiple channels initial support #2055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce BLE_EATT_AUTO_CONNECT syscfg option to allow manual EATT connection setup Introduce a configurable limit for maximum number of L2CAP channels per connection
szymon-czapracki
force-pushed
the
eatt_manual_connection
branch
2 times, most recently
from
a4c3fc3 to
4389896
Compare
Extend ble_eatt struct with channel array and channel count. Add helper functions for channel indexing and lookup. Update ble_eatt_find to search all channels for matching CID. Add channel allocation logic on connect event. Replace direct channel access with indexed lookup. Refactor ble_eatt_tx and L2CAP ev-handler to support multiple channels.
Introduce ble_eatt_connect() API to allow manual setup EATT. This change enables explicit control over EATT channel creation. The function validates the connection handle and requested channel count, supports requesting all channels by passing 0 Add declaration of ble_eatt_connect() to the ble_att.h header.
Introduc a new shell command `gatt_eatt_connect` to allow manual connection of multiple EATT channels per connection. The command parses the connection handle and requested number of channels, displays basic usage help, and calls the internal `ble_eatt_connect()` API. Register the command in the shell, add parameter descriptions and declaration in `cmd_gatt.h`.
szymon-czapracki
force-pushed
the
eatt_manual_connection
branch
from
4389896 to
0fe92a4
Compare
MariuszSkamra
suggested changes
Aug 21, 2025
Comment on lines
+4667
to
4673
| { | ||
| .sc_cmd = "gatt-eatt-connect", | ||
| .sc_cmd_func = cmd_gatt_eatt_connect, | ||
| #if MYNEWT_VAL(SHELL_CMD_HELP) | ||
| .help = &gatt_eatt_connect_help, | ||
| #endif | ||
| }, |
Contributor
There was a problem hiding this comment.
Make it conditional (on MYNEWT_VAL(BLE_EATT_CHAN_NUM));
It has to be conditionally compiled, otherwise it will fail, because gatt_eatt_connect_help is undefined if BLE_EATT_CHAN_NUM is not set
Comment on lines
+698
to
+699
| console_printf("To enable this features set BLE_EATT_CHAN_NUM\n"); | ||
| return ENOTSUP; |
Contributor
There was a problem hiding this comment.
IMO The function should be conditionally compiled as well
Comment on lines
579
to
+586
| eatt = ble_eatt_find(conn_handle, cid); | ||
| if (!eatt || !eatt->chan) { | ||
| if (!eatt) { | ||
| BLE_EATT_LOG_ERROR("Eatt not available"); | ||
| rc = BLE_HS_ENOENT; | ||
| goto error; | ||
| } | ||
|
|
||
| channel = ble_eatt_channel_find_by_cid(eatt, cid); |
Contributor
There was a problem hiding this comment.
This looks odd to me. If ble_eatt_find() takes as parameter cid, I would expect it will return eatt instance matching cid given. Now, when you place an array of channels into eatt so it does not simply wrap L2CAP channel, the ble_eatt_find() should not take cid as parameter IMO.
Comment on lines
+313
to
+315
| chan_idx = ble_eatt_free_channel_idx(eatt); | ||
| if (chan_idx > 0) { | ||
| eatt->chan[chan_idx] = event->connect.chan; |
Contributor
There was a problem hiding this comment.
Probably, the condition is incorrect, as array index 0 is valid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New syscfg options for multiple EATT channels.
Introduce multiple channels to
ble_eattstructure.Add new API function for connecting EATT on demand.
Add new shell command for manually connecting EATT channels.