Skip to content

ll: Fix use after free in ble_ll_isoal_mux_free #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2025
+4 −9
Merged

ll: Fix use after free in ble_ll_isoal_mux_free #2146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions nimble/controller/src/ble_ll_isoal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,24 +60,19 @@ void
ble_ll_isoal_mux_free(struct ble_ll_isoal_mux *mux)
{
struct os_mbuf_pkthdr *pkthdr;
struct os_mbuf *om;
struct os_mbuf *om_next;

pkthdr = STAILQ_FIRST(&mux->sdu_q);
while (pkthdr) {
om = OS_MBUF_PKTHDR_TO_MBUF(pkthdr);
/* remove from list before freeing om */
STAILQ_REMOVE_HEAD(&mux->sdu_q, omp_next);

while (om) {
om_next = SLIST_NEXT(om, om_next);
os_mbuf_free(om);
om = om_next;
}
os_mbuf_free_chain(OS_MBUF_PKTHDR_TO_MBUF(pkthdr));

STAILQ_REMOVE_HEAD(&mux->sdu_q, omp_next);
pkthdr = STAILQ_FIRST(&mux->sdu_q);
}

STAILQ_INIT(&mux->sdu_q);
mux->sdu_q_len = 0;
}

void
Expand Down
Loading