nimble/host: Fix the iso connection handle type#2217
Open
MariuszSkamra wants to merge 3 commits intoapache:masterfrom
Open
nimble/host: Fix the iso connection handle type#2217MariuszSkamra wants to merge 3 commits intoapache:masterfrom
MariuszSkamra wants to merge 3 commits intoapache:masterfrom
Conversation
This fixes the connection handle type, which is two octet value as per Core specification.
This sets the initial conn handle value to 0xFFFF, which is the value outside of valid range.
This refactors ble_iso_big_conn_handles_init macro into function. Few asserts have been added to catch the potential issues. The nested loop has been removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the connection handle type, which is a two-octet value as per the Core specification. The initial value is set to 0xFFFF, which is outside of the valid range, meaning the connection handle is uninitialized.
The ble_iso_big_conn_handles_init macro has been converted into a function. A few asserts have been added to catch potential issues, and the nested loop has been removed.