Skip to content

fixing formatter issues #8484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lahodaj merged 1 commit into from
May 26, 2025
Merged

fixing formatter issues #8484

lahodaj merged 1 commit into from
May 26, 2025

Conversation

@naren2605
Copy link
Contributor

@naren2605 naren2605 commented May 5, 2025 •
edited
Loading

providing fix for issue

  • root cause:
    • a pair {} of braces are injected at the erroneous then part in IfTree
    • improper end position of erroneous block as sp.getStartPosition and sp.getEndPosition always returns begining index for erroneous then statement
    • due to above issues new braces were injected, new lines and indentation has issues which was causing more problems in user experience while formatting long files

@naren2605
Copy link
Contributor Author

naren2605 commented May 5, 2025

requesting @jlahoda , @mbien @dbalek to take a look

@mbien mbien added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label May 5, 2025
@mbien mbien linked an issue May 5, 2025 that may be closed by this pull request
Formatting alters content #8483
Closed
mbien
mbien reviewed May 5, 2025
View reviewed changes
@naren2605 naren2605 requested review from mbien and neilcsmith-net May 5, 2025 12:21
@naren2605
Copy link
Contributor Author

naren2605 commented May 9, 2025

requesting @dbalek to take a look

@naren2605
Copy link
Contributor Author

naren2605 commented May 16, 2025

@mbien ive squashed all commits

@lahodaj
Copy link
Contributor

lahodaj commented May 22, 2025

Unless there are objections, I'll merge this sometime soon, based on Dusan's review.

@mbien mbien added this to the NB27 milestone May 22, 2025
@lahodaj lahodaj merged commit 46c42e4 into apache:master May 26, 2025
36 checks passed
@naren2605 naren2605 mentioned this pull request Jun 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbalek dbalek dbalek approved these changes

@mbien mbien Awaiting requested review from mbien

@neilcsmith-net neilcsmith-net Awaiting requested review from neilcsmith-net

Assignees

No one assigned

Labels

Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)

Projects

None yet

Milestone

NB27

Development

Successfully merging this pull request may close these issues.

Formatting alters content

5 participants

@naren2605 @lahodaj @mbien @neilcsmith-net @dbalek