MINIFICPP-2683 Move C2 docker tests to modular docker tests#2089
Open
lordgamez wants to merge 3 commits intoapache:mainfrom
Open
MINIFICPP-2683 Move C2 docker tests to modular docker tests#2089lordgamez wants to merge 3 commits intoapache:mainfrom
lordgamez wants to merge 3 commits intoapache:mainfrom
Conversation
lordgamez
added
depends-on-another-PR
low-impact
8 tasks
lordgamez
force-pushed
the
MINIFICPP-2683
branch
from
c85588c to
9078384
Compare
lordgamez
force-pushed
the
MINIFICPP-2684
branch
from
23f0367 to
544f99c
Compare
lordgamez
force-pushed
the
MINIFICPP-2683
branch
from
9078384 to
05ba7b1
Compare
szaszm
approved these changes
Jan 30, 2026
lordgamez
force-pushed
the
MINIFICPP-2683
branch
from
05ba7b1 to
7037f68
Compare
fgerlits
reviewed
Feb 2, 2026
behave_framework/src/minifi_test_framework/containers/minifi_container.py
Outdated
Show resolved
Hide resolved
fgerlits
approved these changes
Feb 12, 2026
martinzink
approved these changes
Feb 17, 2026
martinzink
requested changes
Feb 17, 2026
Comment on lines
254
to
259
| @then("the MiNiFi C2 server logs contain the following message: \"{log_message}\" in less than {duration}") | ||
| def step_impl(context: MinifiTestContext, log_message: str, duration: str): | ||
| duration_seconds = humanfriendly.parse_timespan(duration) | ||
| assert wait_for_condition(condition=lambda: log_message in context.containers["minifi-c2-server"].get_logs(), | ||
| timeout_seconds=duration_seconds, bail_condition=lambda: context.containers["minifi-c2-server"].exited, | ||
| context=context) |
Member
There was a problem hiding this comment.
here aswell it might be better to put this in the standard processors steps.py not here
| self.properties["nifi.c2.root.classes"] = "DeviceInfoNode,AgentInformation,FlowInformation,AssetInformation" | ||
| self.properties["nifi.c2.full.heartbeat"] = "false" | ||
| self.properties["nifi.c2.agent.class"] = "minifi-test-class" | ||
| self.properties["nifi.c2.agent.identifier"] = "minifi-test-id" |
Member
There was a problem hiding this comment.
these feel like domain specific functions so they would be better left at the extension level not at the framework
lordgamez
force-pushed
the
MINIFICPP-2683
branch
from
a0210e3 to
366506f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2683
Depends on #2078
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.