MINIFICPP-2686 Move Prometheus tests to modular docker tests#2092
Open
lordgamez wants to merge 2 commits intoapache:MINIFICPP-2685from
Open
MINIFICPP-2686 Move Prometheus tests to modular docker tests#2092lordgamez wants to merge 2 commits intoapache:MINIFICPP-2685from
lordgamez wants to merge 2 commits intoapache:MINIFICPP-2685from
Conversation
lordgamez
added
depends-on-another-PR
low-impact
lordgamez
force-pushed
the
MINIFICPP-2686
branch
from
6805196 to
341714c
Compare
lordgamez
force-pushed
the
MINIFICPP-2685
branch
from
fb6ed88 to
590e174
Compare
lordgamez
force-pushed
the
MINIFICPP-2686
branch
from
341714c to
20c46ea
Compare
lordgamez
force-pushed
the
MINIFICPP-2685
branch
from
590e174 to
2a53e51
Compare
lordgamez
force-pushed
the
MINIFICPP-2686
branch
from
20c46ea to
fed5988
Compare
8 tasks
martinzink
reviewed
Feb 17, 2026
Comment on lines
121
to
136
| def enable_log_metrics_publisher(self): | ||
| self.properties["nifi.metrics.publisher.LogMetricsPublisher.metrics"] = "RepositoryMetrics" | ||
| self.properties["nifi.metrics.publisher.LogMetricsPublisher.logging.interval"] = "1s" | ||
| self.properties["nifi.metrics.publisher.class"] = "LogMetricsPublisher" | ||
|
|
||
| def enable_prometheus(self): | ||
| self.properties["nifi.metrics.publisher.agent.identifier"] = "Agent1" | ||
| self.properties["nifi.metrics.publisher.PrometheusMetricsPublisher.port"] = "9936" | ||
| self.properties["nifi.metrics.publisher.PrometheusMetricsPublisher.metrics"] = "RepositoryMetrics,QueueMetrics,PutFileMetrics,processorMetrics/Get.*,FlowInformation,DeviceInfoNode,AgentStatus" | ||
| self.properties["nifi.metrics.publisher.class"] = "PrometheusMetricsPublisher" | ||
|
|
||
| def enable_prometheus_with_ssl(self): | ||
| self.enable_prometheus() | ||
| self.properties["nifi.metrics.publisher.PrometheusMetricsPublisher.certificate"] = "/tmp/resources/minifi_merged_cert.crt" | ||
| self.properties["nifi.metrics.publisher.PrometheusMetricsPublisher.ca.certificate"] = "/tmp/resources/root_ca.crt" | ||
|
|
Member
There was a problem hiding this comment.
Since prometheus is an extension (although a core one) I think it would be better to have these in the prometheus steps (calling set properties from there) and keep these domain speicifc function out of the framework
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2686
Depends on #2091
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.