Skip to content

Conversation

@joewitt
Copy link
Contributor

@joewitt joewitt commented Nov 13, 2025

Summary

NIFI-15218

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction @joewitt! +1 merging

@exceptionfactory exceptionfactory merged commit 50794ce into apache:main Nov 13, 2025
7 checks passed
@dan-s1
Copy link
Contributor

dan-s1 commented Nov 13, 2025

@exceptionfactory I was responsible for the TailFile change in NIFI-15164. How come when I committed that change did the failure of this IT test not show up in the integration tests?

@exceptionfactory
Copy link
Contributor

@exceptionfactory I was responsible for the TailFile change in NIFI-15164. How come when I committed that change did the failure of this IT test not show up in the integration tests?

Thanks for following up @dan-s1. No problem on the change, it is one of the non-obvious tests that is more tightly coupled to extension components than might be helpful. The renaming did not trigger the integration tests, so that is why the pull request did not show any build issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants