Skip to content

Conversation

@mark-bathori
Copy link
Contributor

The proposed solution uses a FlowFile filter designed to avoid possible performance degradation by grouping FlowFiles that share the same hostname and share values. This grouping is combined with the already existing batch size property. While these changes may alter the order of FlowFiles when the processor is used with different hostname and share values, I believe this change will not significantly impact the SMB processor, given that the original behavior is retained.

Summary

NIFI-14443

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@turcsanyip
Copy link
Contributor

@mark-bathori Thanks for the improvement. At first glance, it looks good overall. Will test it later.
I think some unit tests would be useful for the new FlowFileFilter and a TestRunner test could also be added in PutSmbFileTest for this new use case.
Thanks

@turcsanyip turcsanyip self-requested a review November 18, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants