Skip to content

Conversation

@masc2008
Copy link
Contributor

@masc2008 masc2008 commented Jan 1, 2026

avoid trap when run "iptables -L" if configured CONFIG_NET_NAT while not configured CONFIG_NET_IPFILTER
It's a trap happen everytime.

It's a trap happen everytime.

it can fix issue: #3294

Copy link
Contributor Author

@masc2008 masc2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[BUG] trap when run "iptables -L" if configured CONFIG_NET_NAT while not configure CONFIG_NET_IPFILTER #3294 #3294

@xiaoxiang781216
Copy link
Contributor

@masc2008 please fix:

../nuttx/tools/checkpatch.sh -c -u -m -g 85539a1223c4770ee36e68817f5bfe91e6b49369..HEAD
❌ Commit subject too long > 80
❌ Missing Signed-off-by
Used config files:
    1: .codespellrc
Some checks failed. For contributing guidelines, see:

@masc2008 masc2008 force-pushed the master branch 3 times, most recently from 829cba5 to 2b35fe5 Compare January 1, 2026 09:43
@masc2008
Copy link
Contributor Author

masc2008 commented Jan 1, 2026

updated the commit info, please further review.

@cederom
Copy link
Contributor

cederom commented Jan 8, 2026

Still codespell needs a fix :-)

@masc2008
Copy link
Contributor Author

sorry, but I didn't realize which typo should be fixed. while I updated the comments first. thanks!

@xiaoxiang781216
Copy link
Contributor

sorry, but I didn't realize which typo should be fixed. while I updated the comments first. thanks!

git commit -s --amend to add signoff to the commit message, @masc2008

A trap occurs every time CONFIG_NET_NAT is enabled while CONFIG_NET_IPFILTER is not.

Signed-off-by: Jerry Ma <[email protected]>
@masc2008
Copy link
Contributor Author

thanks, I thought the "Signed-off-by" info will be added automatically when it was merged.

Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @masc2008 :-) Let's just make sure CI builds fine this time :-)

@linguini1 linguini1 merged commit 7daac30 into apache:master Jan 11, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] trap when run "iptables -L" if configured CONFIG_NET_NAT while not configure CONFIG_NET_IPFILTER

5 participants